Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste From Word Filter is not integrated with DIV mode #816

Open
mlewand opened this issue Aug 22, 2017 · 1 comment
Open

Paste From Word Filter is not integrated with DIV mode #816

mlewand opened this issue Aug 22, 2017 · 1 comment
Labels
plugin:pastefromword The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 22, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open a document with few paragraphs of text in MS Word.
  2. Select all.
  3. Copy.
  4. Open https://codepen.io/mlewand/pen/KvRBbq
  5. Paste the content into CKEditor.
  6. Put cursor in the first pasted paragraph.

Expected result

Elements path must not include p elements.

Actual result

Elements path does include a p element.

Other details

It's a regression since 4.6.0.

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.7.2
@mlewand mlewand added plugin:pastefromword The plugin which probably causes the issue. regression This issue is a regression. type:bug A bug. labels Aug 22, 2017
@msamsel
Copy link
Contributor

msamsel commented Aug 24, 2017

Change most probably need to be made somewhere here:
https://github.com/ckeditor/ckeditor-dev/blob/60d63d2dafbdf0bf324d3206c3eac8fb6c76efb0/plugins/pastefromword/filter/default.js#L114-L161

Regression exists because we're missing this feature: https://github.com/ckeditor/ckeditor-dev/blob/3876e730d418107f791eef517178b0048a2c9383/plugins/pastefromword/filter/default.js#L840-L842

It's necessary to remember that paragraphs and divs can have custom style configuration which should be included: https://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-format_div https://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-format_p

@msamsel msamsel added the status:confirmed An issue confirmed by the development team. label Aug 30, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Feb 5, 2018
@mlewand mlewand added this to the Backlog milestone Feb 5, 2018
@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
@f1ames f1ames added the size:M label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:pastefromword The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants