Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons/commands state is based only on start of the selection #772

Open
f1ames opened this issue Aug 11, 2017 · 0 comments
Open

Buttons/commands state is based only on start of the selection #772

f1ames opened this issue Aug 11, 2017 · 0 comments
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@f1ames
Copy link
Contributor

f1ames commented Aug 11, 2017

Are you reporting a feature request or a bug?

Feature request

Check if the issue is already reported

Similar to #525

Provide detailed reproduction steps (if any)

Justify button are disabled when disallowed element is selected. However, when allowed element is partially selected together with disallowed element, buttons are enabled. It only happens when selection starts in allowed element and ends in disallowed one:

screen shot 2017-08-11 at 13 15 38

For the reverse situation, buttons are disabled:

screen shot 2017-08-11 at 13 15 53

This is visible after implementing #455, however it might be also a case for other plugins. So basically, buttons/commands state should not be based on the beginning of the selection, but maybe it should be based on a whole selection (so such inconsistent situations as the one above does not take place).

@f1ames f1ames added status:confirmed An issue confirmed by the development team. type:feature A feature request. labels Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

1 participant