Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorbutton plugin should utilize official API for getting color from dialog #590

Closed
Comandeer opened this issue Jun 30, 2017 · 0 comments
Closed

Colorbutton plugin should utilize official API for getting color from dialog #590

Comandeer opened this issue Jun 30, 2017 · 0 comments
Assignees
@beatadelura
Labels
type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.7.2

Comments

@Comandeer
Copy link
Member

Are you reporting a feature or a bug?

Task

Description

Color Dialog plugin exposes public method for getting selected color, getColorFromDialog. However Color Button plugin, the main user of Color Dialog, is not using it internally. It reinvents it with its own dialog handler. It would be nice to reuse official API here.

Other details

  • Installed CKEditor plugins: colorbutton, colordialog
@Comandeer Comandeer added the type:task Any other issue (refactoring, typo fix, etc). label Jun 30, 2017
@Comandeer Comandeer added this to the Backlog milestone Jun 30, 2017
@mlewand mlewand mentioned this issue Jun 30, 2017
Merged
2 tasks
This was referenced Jul 5, 2017
Closed
Closed
@beatadelura beatadelura mentioned this issue Jul 17, 2017
Merged
2 tasks
@beatadelura beatadelura self-assigned this Jul 19, 2017
@mlewand mlewand modified the milestones: 4.7.2, Backlog Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beatadelura beatadelura

Labels
type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.7.2
Development

No branches or pull requests
3 participants
@Comandeer @mlewand @beatadelura