Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release tests fails on major branch: tests/plugins/pastefromword/generated/tickets2 #2806

Closed
engineering-this opened this issue Feb 13, 2019 · 2 comments · Fixed by #2809
Closed

Release tests fails on major branch: tests/plugins/pastefromword/generated/tickets2 #2806

engineering-this opened this issue Feb 13, 2019 · 2 comments · Fixed by #2809
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:pastefromword The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:failingtest A failing test.
Milestone
4.12.0

Comments

@engineering-this
Copy link
Contributor

Type of report

Failing test

Provide detailed reproduction steps (if any)

Test in tests/plugins/pastefromword/generated/tickets2 fails in current major branch

Actual result

screenshot 2019-02-13 at 12 08 43

☝️most likely this was introduced with Page Break support in PFW.
@engineering-this engineering-this added status:confirmed An issue confirmed by the development team. plugin:pastefromword The plugin which probably causes the issue. type:failingtest A failing test. labels Feb 13, 2019
@engineering-this engineering-this changed the title release tests fails on major branch: tests/plugins/pastefromword/generated/tickets2 Release tests fails on major branch: tests/plugins/pastefromword/generated/tickets2 Feb 13, 2019
@engineering-this engineering-this mentioned this issue Feb 13, 2019
Merged
2 tasks
@mlewand
Copy link
Contributor

mlewand commented Feb 13, 2019

@jacekbogdanski please take a look at it, whether #2598 breaks unit tests in the built version.

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Feb 13, 2019 •
edited
Loading

I can confirm that #2598 breaks unit test. pagebreak plugin is loaded implicitly when building an editor and changes the unit test output. I will submit a fix in a moment.

@jacekbogdanski jacekbogdanski mentioned this issue Feb 13, 2019
Merged
2 tasks
@mlewand mlewand added the changelog:skip A changelog entry should not be added for a given issue. label Feb 14, 2019
@mlewand mlewand added this to the 4.12.0 milestone Feb 14, 2019
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:pastefromword The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:failingtest A failing test.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Fix failing test caused by pagebreak PFW integration ckeditor/ckeditor4
3 participants
@mlewand @jacekbogdanski @engineering-this