Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji shouldn't show dropdown when inside a text #2195

Closed
jacekbogdanski opened this issue Jul 2, 2018 · 0 comments
Closed

Emoji shouldn't show dropdown when inside a text #2195

jacekbogdanski opened this issue Jul 2, 2018 · 0 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.10.1

Comments

@jacekbogdanski
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open http://tests.ckeditor.test:1030/tests/plugins/emoji/manual/emoji
  2. Type foo:fa.

Expected result

Nothing happens.

Actual result

Emoji dropdown shows up.

Other details

In the current implementation emoji triggers dropdown inside sentence with : character. It's little awkward especially if you set config.minChars = 0. We handled this issue inside mentions plugin and I think it should be also handled in emoji.

  • CKEditor version: 4.10.0
  • Installed CKEditor plugins: emoji
@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:emoji The plugin which probably causes the issue. labels Jul 2, 2018
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jul 9, 2018
@engineering-this engineering-this mentioned this issue Jul 9, 2018
Merged
2 tasks
@mlewand mlewand added this to the 4.10.1 milestone Aug 3, 2018
@mlewand mlewand mentioned this issue Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
2 participants
@mlewand @jacekbogdanski