Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS Edge 17 - paste image from another tab causes TypeError for isBlock #2169

Closed
kylane opened this issue Jun 26, 2018 · 3 comments
Closed

MS Edge 17 - paste image from another tab causes TypeError for isBlock #2169

kylane opened this issue Jun 26, 2018 · 3 comments
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.10.1

Comments

@kylane
Copy link

kylane commented Jun 26, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Using CKEditor build 4.9.2 in a React project in Microsoft Edge 17
  2. Copy an image from another tab within Edge
  3. Paste image into the CKEditor

Expected result

No console error.

Actual result

Console error: Unable to get property 'isBlock' of undefined or null reference

Other details

  • Browser: Microsoft Edge 17
  • OS: Win10
  • CKEditor version: 4.9.2
  • Installed CKEditor plugins: clipboard, dialog, specialchar
@jacekbogdanski jacekbogdanski self-assigned this Jun 26, 2018
@jacekbogdanski
Copy link
Member

Hello,

I can reproduce the issue. It seems to work natively so it's not an Edge upstream.

@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. labels Jun 26, 2018
@jacekbogdanski jacekbogdanski removed their assignment Jun 26, 2018
@kylane
Copy link
Author

kylane commented Jun 29, 2018

Thanks @jacekbogdanski!

More to this issue - after using a clipboard viewer, edge seems to copy a bunch of wacky (word-like) tags - and adding the pasteFilter: 'semantic-content' seemed to filter out most of that junk before being handed to the ACF - which then did its thing correctly. I note that its on by default for CH and FF, but not MS* - but specifically setting it seemed to fix my issue above.

@kylane kylane closed this as completed Jun 29, 2018
@kylane kylane reopened this Jun 29, 2018
@engineering-this
Copy link
Contributor

This is upstream issue with Edge 17,
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18089287/

However workaround for this is quite simple and I will propose PR for that.

@engineering-this engineering-this mentioned this issue Jun 29, 2018
Merged
2 tasks
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Jul 3, 2018
@Comandeer Comandeer added this to the 4.10.1 milestone Jul 5, 2018
@gingebaker gingebaker mentioned this issue Sep 13, 2018
Closed
@jswiderski jswiderski mentioned this issue Nov 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
5 participants
@Comandeer @mlewand @kylane @jacekbogdanski @engineering-this