Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji matching should be case insensitive #2167

Closed
mlewand opened this issue Jun 25, 2018 · 1 comment
Closed

Emoji matching should be case insensitive #2167

mlewand opened this issue Jun 25, 2018 · 1 comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.10.1

Comments

@mlewand
Copy link
Contributor

mlewand commented Jun 25, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

Emoji matching should be case insensitive.

ATM there are some emojis like :OK_hand:, and since there is no case insenstivity, typing :ok_ will not match this emoji.

Matches for :OK_ phrase

No matches for lowercased :ok_ phrase

Expected result

Matches should be case insensitive.

Actual result

Letter casing matters.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.10.0
  • Installed CKEditor plugins: emoji
@mlewand mlewand added type:bug A bug. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. plugin:emoji The plugin which probably causes the issue. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jun 25, 2018
@wwalc wwalc mentioned this issue Jun 27, 2018
Closed
@mlewand mlewand added this to the Backlog milestone Jun 27, 2018
@engineering-this engineering-this mentioned this issue Jun 27, 2018
Merged
2 tasks
@mlewand mlewand modified the milestones: Backlog, 4.10.1 Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
2 participants
@mlewand and others