Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell properties dialog has locked height unit type #2084

Closed
engineering-this opened this issue Jun 13, 2018 · 1 comment · Fixed by #3075
Closed

Cell properties dialog has locked height unit type #2084

engineering-this opened this issue Jun 13, 2018 · 1 comment · Fixed by #3075
Assignees
@Dumluregn
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:tabletools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.12.0

Comments

@engineering-this
Copy link
Contributor

engineering-this commented Jun 13, 2018 •
edited by mlewand
Loading

Type of report

New Feature

Provide detailed reproduction steps (if any)

  1. Open http://cdn.ckeditor.com/4.9.2/full-all/samples/index.html
  2. Clear editor contents and create a new table.
  3. Open context menu and choose cell properties.

Expected result

Cell height can be changed from pixels to percentage unit.

Actual result

Cell height unit is text instead of a select.

Other details

  • CKEditor version: 4.9.2
  • Installed CKEditor plugins: tabletools
    screen shot 2018-06-13 at 16 58 05
@engineering-this engineering-this added status:confirmed An issue confirmed by the development team. plugin:tabletools The plugin which probably causes the issue. labels Jun 13, 2018
@mlewand mlewand added type:feature A feature request. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. labels Jun 14, 2018
@mlewand
Copy link
Contributor

mlewand commented Jun 14, 2018 •
edited
Loading

Changed issue type to a feature request.

@engineering-this engineering-this mentioned this issue Aug 23, 2018
Merged
2 tasks
@Dumluregn Dumluregn mentioned this issue Apr 25, 2019
Merged
2 tasks
@f1ames f1ames added this to the 4.12.0 milestone May 17, 2019
@Dumluregn Dumluregn self-assigned this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:tabletools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Add unit type selection for table cell height ckeditor/ckeditor4
4 participants
@f1ames @mlewand @Dumluregn @engineering-this