Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing headers from table with one row fails #1397

Closed
b2m opened this issue Jan 3, 2018 · 2 comments
Closed

Removing headers from table with one row fails #1397

b2m opened this issue Jan 3, 2018 · 2 comments
Labels
plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.4

Comments

@b2m
Copy link

b2m commented Jan 3, 2018 •
edited
Loading

Are you reporting a feature request or a bug?

Bug because simple GUI Usage leads to JavaScript Error.

Provide detailed reproduction steps (if any)

  1. Go to https://codepen.io/anon/pen/goxWEe?editors=1010
  2. Open the Table Properties (e.g. via the Context Menu)
  3. Change Headers to "None"

Expected result

The Headers of the table are removed.

Actual result

JavaScript Error: TypeError: Cannot read property '$' of null

Other details

  • Browser: Chrome, Firefox, ...
  • OS: Linux, Windows, ...
  • CKEditor version: 4.8.0 and earlier
  • Installed CKEditor plugins: table, tabletools, maybe more
@msamsel
Copy link
Contributor

msamsel commented Jan 4, 2018

Problem is possible to reproduce on our sample.
Additional option to reproduce:

  1. Copy and past to sourcearea:
<table border="1" cellspacing="1" cellpadding="1" style="width:500px;"><thead><tr><th scope="row"><br></th><th scope="col"><br></th></tr></thead><tbody></tbody></table>
  1. Open table properties and change header to none.

@msamsel msamsel added status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jan 4, 2018
@mlewand mlewand added plugin:table The plugin which probably causes the issue. target:minor Any docs related issue that can be merged into a master or major branch. labels Jan 4, 2018
@engineering-this engineering-this mentioned this issue Jan 16, 2018
Merged
2 tasks
@f1ames f1ames mentioned this issue Mar 4, 2019
Closed
@f1ames f1ames added this to the 4.11.4 milestone Mar 8, 2019
@f1ames
Copy link
Contributor

f1ames commented Mar 8, 2019

Closed with 2675ac8.

@f1ames f1ames closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.4
Development

No branches or pull requests
4 participants
@b2m @f1ames @mlewand @msamsel