Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using 'Automatic' color on text with already applied color creates 'span.style=color:null' #1084

Closed
f1ames opened this issue Oct 24, 2017 · 1 comment
Closed

Using 'Automatic' color on text with already applied color creates 'span.style=color:null' #1084

f1ames opened this issue Oct 24, 2017 · 1 comment
Labels
regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.10.1

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 24, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://sdk.ckeditor.com/samples/fullpreset.html.
  2. Set content to foo bar.
  3. Select bar and change text color to some predefined/custom one.
  4. Select bar and change text color to Automatic.

Expected result

Span element with color is removed producing content like <p>foo bar</p>.

Actual result

Span element with color is not removed but modified with a null color producing html like <p>foo <span style="color:null">bar</span></p>

Other details

  • Browser: All (checked in Chrome and FF)
  • OS: All
  • CKEditor version: 4.7.2
  • Installed CKEditor plugins: colorbutton
@f1ames f1ames added regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Oct 24, 2017
@mlewand mlewand added this to the Backlog milestone Jan 19, 2018
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Jan 19, 2018
@engineering-this engineering-this mentioned this issue Jul 9, 2018
Merged
2 tasks
@mlewand
Copy link
Contributor

mlewand commented Jul 17, 2018 •
edited
Loading

Breaking commit: 0db4395 introduced in #652.

@mlewand mlewand modified the milestones: Backlog, 4.10.1 Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
2 participants
@f1ames @mlewand