-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification plugin collides and overwrites Web Notifications API #1057
Comments
I cannot reproduce problem on our sample: https://cdn.ckeditor.com/4.7.3/full-all/samples/. CKEditor should not leak to global scope except If you are able to reproduce issue without 3rd party plugins, please provide more detailed steps how to repeat such situation. |
@msamsel, the issue can only be reproduced with the Notification plugin enabled which seems to be leaking to global scope. Since the Notification plugin is shipped with CKEditor, is it still considered a third party plugin that you don't support? |
@CExWHamdan I gave you such information, because I'm not able to reproduce the problem. Please provide an example (it can be on page like codepen, jsfiddle, etc.) or reproduction steps which will allow on repeating this problem. |
Thanks @msamsel for looking into the issue. Here's a demo where the issue can be reproduced: https://jsfiddle.net/n0m8pf3a/1/ The demo demonstrates the state of global Notification before and after instantiating a simple CKEditor with the |
Issue does not occur in actual (4.7.3) version of CKEditor. |
@msamsel This is a still valid issue. If you check the dev version, you're still able to reproduce it there. ExplainationThe reason why you're unable to reproduce it is that you use 4.7.x version - where The jsfiddle example provided by @CExWHamdan uses 4.6.x where We must never leak any global vars other than |
Are you reporting a feature request or a bug?
Bug
Provide detailed reproduction steps (if any)
Notification
Expected result
Web Notifications API should be returned.
Actual result
CKEditor Notification plugin is returned.
Other details
The text was updated successfully, but these errors were encountered: