Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"border-color" in tables gets removed #1010

Closed
jswiderski opened this issue Oct 5, 2017 · 3 comments
Closed

"border-color" in tables gets removed #1010

jswiderski opened this issue Oct 5, 2017 · 3 comments
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

Provide detailed reproduction steps (if any)

  1. Set ACF to config.extraAllowedContent = 'td{border-color,border-style,border-width}';.
  2. Open replacebycode.html sample in IE11.
  3. Switch to source mode and paste:
<table style="width:500px">
<tbody>
<tr>
<td style="border-color:red; border-style:solid; border-width:2pt">&nbsp;</td>
<td>&nbsp;</td>
</tr>
</tbody>
</table>
  1. Switch to wysiwyg mode.

Expected result

Broder in first cell is red.

Actual result

Broder in first cell isn't red and when inspecting HTML with dev-tools, you can see that border-color:red; gets removed.

Other details

  • Browser: IE11
  • OS: Windoes
  • CKEditor version: 4.6+
  • Installed CKEditor plugins: table, tabletools

Problem can be reproduced in IE11 from CKEditor 4.6.0.

@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. support An issue reported by a commercially licensed client. labels Oct 5, 2017
@sebastien-roch
Copy link

This is a pen to reproduce:
https://codepen.io/sebastien-roch/pen/BweLBr

I can confirm it happens only on IE10+, Chrome and Firefox work fine.

@mlewand mlewand added this to the Backlog milestone Oct 24, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Dec 15, 2017
@mlewand
Copy link
Contributor

mlewand commented Dec 15, 2017

Let's have a look at it as a candidate for 4.8.1 or a next minor release.

@f1ames
Copy link
Contributor

f1ames commented Dec 19, 2017

To put a little more perspective on this issue, this is a general issue in all browsers related to splitBorderShorthand method (which apparently does not parse border color).

For HTML provided in reproduction steps it was only visible in IE as there border-color:red; border-style:solid; border-width:2pt styles are normalized to shorthand form and then wrongly interpreted by splitBorderShorthand method.

To reproduce the issue in other browsers, it is enough to use shorthand form (border:2pt solid red) instead of the full one: see sample codepen.

@f1ames f1ames removed the browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. label Dec 19, 2017
@f1ames f1ames changed the title [IE11] "border-color" gets removed. "border-color" gets removed Dec 19, 2017
@f1ames f1ames modified the milestones: Backlog, 4.8.1 Jan 15, 2018
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
@mlewand mlewand changed the title "border-color" gets removed "border-color" in tables gets removed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants