-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add /rgbpp/v1/address/:address/balance for get bound xUDT balance #146
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a5f1b91
to
3036250
Compare
b76cbdf
to
b017885
Compare
Co-authored-by: Flouse <[email protected]>
Co-authored-by: Flouse <[email protected]>
b017885
to
15d7d15
Compare
expect(data).toEqual({ | ||
decimal: 8, | ||
name: 'XUDT Test Token', | ||
symbol: 'XTT', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The symbol
of https://pudge.explorer.nervos.org/xudt/0x10f511f2efb0027191b97ac5b4bd77374ffdac7399e8527d76f5f9bd32e7d35b is PDD, not XTT.
It might be a bug of Explorer.
Reason
The token owner has issued PDD
in a previous tx https://pudge.explorer.nervos.org/transaction/0x6a35da16ab1198008545c78b91abe22999f0dc823055553a13d7de29f3063111
I think we can ignore this situation for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you add the unconfirmed balance/amount
data type in this PR or another PR?
Yes, I will open a PR for that |
11c0446
to
b99a1ad
Compare
|
||
test('getUniqueCellData: should return the unique cell data', async () => { | ||
// XTT (Unique cell transaction) | ||
const tx = await ckb.rpc.getTransaction('0xe6e23718e45a9c36136367dfb1c47397a7b3db2ff130a1c062f40c795f0b103d'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to change the test case to PDD
: https://pudge.explorer.nervos.org/transaction/0x6a35da16ab1198008545c78b91abe22999f0dc823055553a13d7de29f3063111
context: #146 (comment)
Changes
add
/rgbpp/v1/address/:address/balance
for get bound xUDT balanceThe implementation logic is as follows:
Response data example:
References