CKAN 2.9 / Python 3 #55
Conversation
| @@ -4,6 +4,8 @@ | |||
| import cgi | |||
| import json | |||
|
|
|||
| import six | |||
| from werkzeug.datastructures import FileStorage as FlaskFileStorage | |||
There was a problem hiding this comment.
Won't this be incompatible with CKAN < 2.8?
| controller = u'ckanext.validation.controller:ValidationController' | ||
|
|
||
| map_.connect( | ||
| u'validation_read', |
There was a problem hiding this comment.
Is there a consistent named route that templates can use to work with either Flask or Pylons without alteration?
|
#56 fixes some of the errors but there are other problems that I'm unsure how to resolve, such as 'enqueue_job' not being called. |
- can't automatically serialize to JSON otherwise
|
Our fork and Keitaro's (qld-gov-au and keitaroinc) now have Py3 compatibility, if you want to use them as a reference. Keitaro is using the ckan-dev Docker containers, which preload more and result in a faster build, while qld-gov-au has scenario tests using Behave, but they'll otherwise be quite similar if/when keitaroinc#11 is merged. |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage ? 82.64%
=========================================
Files ? 26
Lines ? 2149
Branches ? 0
=========================================
Hits ? 1776
Misses ? 373
Partials ? 0 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
[QOLDEV-323] pin test container version to preserve Docker Compose
Putting this out there in case someone wants to pick it up. I sadly run out of time before completion but I'd say that the py3/CKAN 2.9 support is 80% there, with still some things to iron out.