forked from apache/doris
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fix](schema change) Fix can't do reorder column schema change for MO…
…W table and duplicate key table (apache#37067) ## Proposed changes 1. set column's field `isAggregationTypeImplicit` correctly for mow table and duplicate key table to let `SchemaChangeHandler::createJob` can recognize that the schema change is a column reorder case. 2. remove useless test cases `test_schema_change_datev2_with_delete`, `test_dup_keys_schema_change_datev2`. These two cases wanted to test schema change from `datev1`/`datetimev1` to `datev2`/`datetimev2`. But the default type of columns created as `date`/`datetime` are already `datev2`/`datetimev2` now. Thest test cases should have met error "Nothing is changed. please check your alter stmt." when doris enable `datev2`/`datetimev2` by default but it didn't because `isAggregationTypeImplicit` is wrongly set for duplicate table column.
- Loading branch information
Showing
9 changed files
with
163 additions
and
445 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 0 additions & 81 deletions
81
regression-test/data/schema_change/test_schema_change_datev2_with_delete.out
This file was deleted.
Oops, something went wrong.
70 changes: 0 additions & 70 deletions
70
regression-test/data/schema_change_p0/datev2/test_dup_keys_schema_change_datev2.out
This file was deleted.
Oops, something went wrong.
22 changes: 22 additions & 0 deletions
22
regression-test/data/schema_change_p0/test_modify_reorder_column.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
-- This file is automatically generated. You should know what you did if you want to edit this | ||
-- !dup -- | ||
1 {"f1": "A", "f2": "B", "f3": 10, "f4": 3.14} {"f1": "C", "f2": "D", "f3": 20, "f4": 8.343} {"a":1,"b":[1],"c":1.0} | ||
|
||
-- !dup -- | ||
1 {"f1": "A", "f2": "B", "f3": 10, "f4": 3.14} {"a":1,"b":[1],"c":1.0} {"f1": "C", "f2": "D", "f3": 20, "f4": 8.343} | ||
2 {"f1": "E", "f2": "F", "f3": 30, "f4": 484.3234} {"a":1,"b":[1],"c":1.0} \N | ||
|
||
-- !mor -- | ||
1 {"f1": "A", "f2": "B", "f3": 10, "f4": 3.14} {"f1": "C", "f2": "D", "f3": 20, "f4": 8.343} {"a":1,"b":[1],"c":1.0} | ||
|
||
-- !mor -- | ||
1 {"f1": "A", "f2": "B", "f3": 10, "f4": 3.14} {"a":1,"b":[1],"c":1.0} {"f1": "C", "f2": "D", "f3": 20, "f4": 8.343} | ||
2 {"f1": "E", "f2": "F", "f3": 30, "f4": 484.3234} {"a":1,"b":[1],"c":1.0} \N | ||
|
||
-- !mow -- | ||
1 {"f1": "A", "f2": "B", "f3": 10, "f4": 3.14} {"f1": "C", "f2": "D", "f3": 20, "f4": 8.343} {"a":1,"b":[1],"c":1.0} | ||
|
||
-- !mow -- | ||
1 {"f1": "A", "f2": "B", "f3": 10, "f4": 3.14} {"a":1,"b":[1],"c":1.0} {"f1": "C", "f2": "D", "f3": 20, "f4": 8.343} | ||
2 {"f1": "E", "f2": "F", "f3": 30, "f4": 484.3234} {"a":1,"b":[1],"c":1.0} \N | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 0 additions & 121 deletions
121
regression-test/suites/schema_change/test_schema_change_datev2_with_delete.groovy
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.