Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Date, DateTime #3

Closed
fchorney opened this issue May 27, 2020 · 3 comments · Fixed by #10
Closed

Support Date, DateTime #3

fchorney opened this issue May 27, 2020 · 3 comments · Fixed by #10
Labels
enhancement New feature or request

Comments

@fchorney
Copy link
Contributor

Hi,
First off, thanks for making this package!

I am wondering if you would be open to adding Date and DateTime support to this package, as I would like to use Infinity as an unbounded date for date intervals.
I guess we would need to expand on the InfExtended datatype, or even make something else such as InfDateExtended.

Would you be open to taking a PR that adds this support, as I would love to start working on such a thing right away.

Thanks!

@cjdoris
Copy link
Owner

cjdoris commented May 27, 2020

Thanks. I've just seen your thread over on Intervals.jl --- that's basically the reason I made this package! Maybe they'd be open to linking to this package from their documentation...

Anyway yes, it makes sense to have infinite times. Probably we need a new extended type, something like InfExtendedTime{T<:Dates.TimeType} <: Dates.TimeType (analogous to InfExtended{T<:Real} <: Real). Feel free to make a PR and I'll take a look.

@cjdoris cjdoris added the enhancement New feature or request label Jun 2, 2020
@cjdoris
Copy link
Owner

cjdoris commented Jun 2, 2020

@fchorney If you're working on this, please note that the representation of InfExtended will be changing: #4 (comment). Please give InfExtendedTime the same structure. You can reuse InfFlag.

Also I'm going to restructure the code sometime as in #5, so it would be helpful if you put all your new code into a infextendedtime/ subdirectory. Thanks!

@fchorney
Copy link
Contributor Author

fchorney commented Jun 3, 2020

Ok sounds good. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants