Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in Chrome on Windows - jquery and getUserMedia detection, and non https - PR in comments #40

Closed
manthrax opened this issue Oct 17, 2020 · 1 comment

Comments

@manthrax
Copy link

jquery gets callstack exceeded because the previous modals are not "hide" before the next modal is "show".

getUserMedia in adaptor.js detection doesn't identify chrome... additionally.. if not in HTTPS, getUserMedia doesn't exist.. This can be trivially shimmed around, allowing the datachannel (chat) to work.

There is a loong delay between offer generation and the ICE server result.. 30 seconds or so each way on my setup.. Is this normal?.. would be cool if this was wrapped into a small library.

Cool project!

Here is a PR with what I had to break to get this to work on Chrome/Windows:
Had to force "hide" any open modals before "show" ing the next one, or jquery gets a stack overflow...
I fixed it for the host, but might not have for the client, but it all eventually works...

#39

@cjb
Copy link
Owner

cjb commented Sep 3, 2021

@manthrax Thanks! This should be fixed up on the main branch now.

@cjb cjb closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants