From b5b4e8339d61c2fc1ec9b992d1a2362d522cb71d Mon Sep 17 00:00:00 2001 From: eileen Date: Thu, 21 Nov 2019 14:25:10 +1300 Subject: [PATCH] [REF] further removal of unnecessar params Per @mattwiree digging here https://github.com/civicrm/civicrm-core/pull/15841 we don't need to set vars that are no longer used --- CRM/Contribute/BAO/Contribution.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 0f1a0c635912..950bbb995379 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -4572,14 +4572,6 @@ public static function completeOrder($input, &$ids, $objects, $transaction, $con CRM_Contribute_BAO_ContributionRecur::addrecurSoftCredit($objects['contributionRecur']->id, $contribution->id); } - $contributionStatuses = CRM_Core_PseudoConstant::get('CRM_Contribute_DAO_Contribution', 'contribution_status_id', [ - 'labelColumn' => 'name', - 'flip' => 1, - ]); - if (isset($input['prevContribution']) && (!$input['prevContribution']->is_pay_later && $input['prevContribution']->contribution_status_id == $contributionStatuses['Pending'])) { - $input['payment_processor'] = $paymentProcessorId; - } - if (empty($contribution->_relatedObjects['participant']) && !empty($contribution->_relatedObjects['membership'])) { // @fixme Can we remove this if altogether? - we removed the participant if / else and left relatedObjects['participant'] to ensure behaviour didn't change but it is probably not required. // @todo - use getRelatedMemberships instead