From a4379b4a122cdcb3d4cb958cb0d55ab5c100de7f Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Wed, 12 Apr 2023 09:03:38 +1200 Subject: [PATCH] Remove a couple of unused variables --- CRM/Dedupe/Merger.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/CRM/Dedupe/Merger.php b/CRM/Dedupe/Merger.php index 9e11ed3a1c26..903fdd5f1da9 100644 --- a/CRM/Dedupe/Merger.php +++ b/CRM/Dedupe/Merger.php @@ -1866,10 +1866,10 @@ private static function getTree( $queryString = "$strSelect $strFrom $strWhere $orderBy"; // lets see if we can retrieve the groupTree from cache - $cacheString = $queryString . '_Inline';; + $cacheString = $queryString . '_Inline'; - $cacheKey = "CRM_Core_DAO_CustomGroup_Query " . md5($cacheString); - $multipleFieldGroupCacheKey = "CRM_Core_DAO_CustomGroup_QueryMultipleFields " . md5($cacheString); + $cacheKey = 'CRM_Core_DAO_CustomGroup_Query ' . md5($cacheString); + $multipleFieldGroupCacheKey = 'CRM_Core_DAO_CustomGroup_QueryMultipleFields ' . md5($cacheString); $cache = CRM_Utils_Cache::singleton(); $groupTree = $cache->get($cacheKey); $multipleFieldGroups = $cache->get($multipleFieldGroupCacheKey); @@ -1891,7 +1891,6 @@ private static function getTree( if (isset($groupTree['info']) && !empty($groupTree['info']) && !empty($groupTree['info']['tables']) ) { - $select = $from = $where = []; $groupTree['info']['where'] = NULL; foreach ($groupTree['info']['tables'] as $table => $fields) { @@ -1937,8 +1936,10 @@ private static function getTree( * @param string $column * @param string $value * @param string $delimiter + * * @return string * SQL condition. + * @throws \CRM_Core_Exception */ private static function whereListHas($column, $value, $delimiter = CRM_Core_DAO::VALUE_SEPARATOR) { // ?