From 4d8e91aca2be1d2d2efc69ce4077670215cf5cf7 Mon Sep 17 00:00:00 2001
From: "Matthew Wire (MJW Consulting)" <mjw@mjwconsult.co.uk>
Date: Fri, 19 Oct 2018 21:29:48 +0100
Subject: [PATCH] Convert ManageEvent Registration to datepicker

---
 CRM/Event/Form/ManageEvent/Registration.php   | 34 +++----------------
 .../Event/Form/ManageEvent/Registration.tpl   |  4 +--
 xml/schema/Event/Event.xml                    |  4 +++
 3 files changed, 10 insertions(+), 32 deletions(-)

diff --git a/CRM/Event/Form/ManageEvent/Registration.php b/CRM/Event/Form/ManageEvent/Registration.php
index aed44b7ad48d..a39bc136a542 100644
--- a/CRM/Event/Form/ManageEvent/Registration.php
+++ b/CRM/Event/Form/ManageEvent/Registration.php
@@ -178,16 +178,6 @@ public function setDefaultValues() {
     $defaults['thankyou_title'] = CRM_Utils_Array::value('thankyou_title', $defaults, ts('Thank You for Registering'));
     $defaults['approval_req_text'] = CRM_Utils_Array::value('approval_req_text', $defaults, ts('Participation in this event requires approval. Submit your registration request here. Once approved, you will receive an email with a link to a web page where you can complete the registration process.'));
 
-    if (!empty($defaults['registration_start_date'])) {
-      list($defaults['registration_start_date'], $defaults['registration_start_date_time'])
-        = CRM_Utils_Date::setDateDefaults($defaults['registration_start_date'], 'activityDateTime');
-    }
-
-    if (!empty($defaults['registration_end_date'])) {
-      list($defaults['registration_end_date'], $defaults['registration_end_date_time'])
-        = CRM_Utils_Date::setDateDefaults($defaults['registration_end_date'], 'activityDateTime');
-    }
-
     return $defaults;
   }
 
@@ -250,8 +240,8 @@ public function buildQuickForm() {
     $this->add('text', 'registration_link_text', ts('Registration Link Text'));
 
     if (!$this->_isTemplate) {
-      $this->addDateTime('registration_start_date', ts('Registration Start Date'), FALSE, array('formatType' => 'activityDateTime'));
-      $this->addDateTime('registration_end_date', ts('Registration End Date'), FALSE, array('formatType' => 'activityDateTime'));
+      $this->add('datepicker', 'registration_start_date', ts('Registration Start Date'), [], FALSE, array('time' => TRUE));
+      $this->add('datepicker', 'registration_end_date', ts('Registration End Date'), [], FALSE, array('time' => TRUE));
     }
 
     $params = array(
@@ -482,13 +472,8 @@ public static function formRule($values, $files, $form) {
         }
       }
 
-      if (
-        isset($values['registration_start_date']) &&
-        isset($values['registration_end_date'])
-      ) {
-        $start = CRM_Utils_Date::processDate($values['registration_start_date']);
-        $end = CRM_Utils_Date::processDate($values['registration_end_date']);
-        if ($end < $start) {
+      if (isset($values['registration_start_date']) && isset($values['registration_end_date'])) {
+        if ($values['registration_end_date'] < $values['registration_start_date']) {
           $errorMsg['registration_end_date'] = ts('Registration end date should be after Registration start date');
         }
       }
@@ -821,17 +806,6 @@ public function postProcess() {
       $params['selfcancelxfer_time'] = !empty($params['selfcancelxfer_time']) ? $params['selfcancelxfer_time'] : 0;
     }
 
-    if (!$this->_isTemplate) {
-      $params['registration_start_date'] = CRM_Utils_Date::processDate($params['registration_start_date'],
-        $params['registration_start_date_time'],
-        TRUE
-      );
-      $params['registration_end_date'] = CRM_Utils_Date::processDate($params['registration_end_date'],
-        $params['registration_end_date_time'],
-        TRUE
-      );
-    }
-
     CRM_Event_BAO_Event::add($params);
 
     // also update the ProfileModule tables
diff --git a/templates/CRM/Event/Form/ManageEvent/Registration.tpl b/templates/CRM/Event/Form/ManageEvent/Registration.tpl
index 20e52fd53f87..e4c5361e4a38 100644
--- a/templates/CRM/Event/Form/ManageEvent/Registration.tpl
+++ b/templates/CRM/Event/Form/ManageEvent/Registration.tpl
@@ -72,11 +72,11 @@
   {if !$isTemplate}
     <tr class="crm-event-manage-registration-form-block-registration_start_date">
       <td scope="row" class="label" width="20%">{$form.registration_start_date.label}</td>
-      <td>{include file="CRM/common/jcalendar.tpl" elementName=registration_start_date}</td>
+      <td>{$form.registration_start_date.html}</td>
     </tr>
     <tr class="crm-event-manage-registration-form-block-registration_end_date">
       <td scope="row" class="label" width="20%">{$form.registration_end_date.label}</td>
-      <td>{include file="CRM/common/jcalendar.tpl" elementName=registration_end_date}</td>
+      <td>{$form.registration_end_date.html}</td>
     </tr>
   {/if}
   <tr class="crm-event-manage-registration-form-block-is_multiple_registrations">
diff --git a/xml/schema/Event/Event.xml b/xml/schema/Event/Event.xml
index 200eed0159d8..77a43a7c1011 100644
--- a/xml/schema/Event/Event.xml
+++ b/xml/schema/Event/Event.xml
@@ -122,6 +122,7 @@
     <add>1.7</add>
     <html>
       <type>Select Date</type>
+      <formatType>activityDateTime</formatType>
     </html>
   </field>
   <field>
@@ -135,6 +136,7 @@
     <add>1.7</add>
     <html>
       <type>Select Date</type>
+      <formatType>activityDateTime</formatType>
     </html>
   </field>
   <field>
@@ -167,6 +169,7 @@
     <add>1.8</add>
     <html>
       <type>Select Date</type>
+      <formatType>activityDateTime</formatType>
     </html>
   </field>
   <field>
@@ -176,6 +179,7 @@
     <add>1.8</add>
     <html>
       <type>Select Date</type>
+      <formatType>activityDateTime</formatType>
     </html>
   </field>
   <field>