Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a calendar action and put it in GNB #52

Closed
city-kim opened this issue Oct 5, 2023 · 3 comments · Fixed by #57
Closed

add a calendar action and put it in GNB #52

city-kim opened this issue Oct 5, 2023 · 3 comments · Fixed by #57
Assignees
@city-kim
Labels
enhancement New feature or request

Comments

@city-kim
Copy link
Owner

city-kim commented Oct 5, 2023

#3
이후 작업
캘린더를 GNB에 추가하고 캘린더에 변경에 따른 날짜 변경 및 데이터 업데이트
@city-kim city-kim converted this from a draft issue Oct 5, 2023
@city-kim city-kim self-assigned this Oct 5, 2023
@city-kim city-kim moved this to In Progress in vue report Oct 5, 2023
@city-kim city-kim added the enhancement New feature or request label Oct 5, 2023
@city-kim city-kim changed the title add calendar action adn gnb add a calendar action and put it in GNB Oct 6, 2023
@city-kim
Copy link
Owner Author

city-kim commented Oct 6, 2023 •
edited
Loading

달력이미지
#3 (comment)

@city-kim
Copy link
Owner Author

city-kim commented Oct 8, 2023

  • layout에 HeaderGnb를 추가하고 app에서 사용하도록 추가
    • header의 background가 화면 가득 채우도록 위치 변경
  • css variable에 gray와 orange추가
    • header의 크기를 맞추기 위해 app의 크기 설정을 app.vue로 이동
  • ButtonSingle의 test, story 추가
    • 버튼의 색상을 지정하기 위한 scss의 mixin button-color 추가
  • CompareCalendar의 test, story 추가
    • caret_up, caret_down, calendar_check아이콘 추가
  • HeaderGnb에서 calendar를 조작하도록 추가
  • store의 date의 changeDate -> dateCustomUpdate변경
    • dateDiffUpdate 추가
  • util의 date_converter에 dateSort 추가
  • views의 ChartList 삭제

@city-kim city-kim linked a pull request Oct 8, 2023 that will close this issue
add calendar #57
Merged
2 tasks
@city-kim
Copy link
Owner Author

city-kim commented Oct 8, 2023

테스트중 vm에 접근할때 typescript 오류는
vuejs/test-utils#972
vuejs/test-utils#1746

위 두가지 사항을 참조하여
const vm = wrapper.vm as unknown as ComponentVm
으로 작성됨

@github-project-automation github-project-automation bot moved this from In Progress to Done in vue report Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@city-kim city-kim

Labels
enhancement New feature or request
Projects
vue report
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add calendar city-kim/vue_report
1 participant
@city-kim