Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docker to 9.4.0 #194

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Bump docker to 9.4.0 #194

merged 3 commits into from
Jul 28, 2020

Conversation

onurctirtir
Copy link
Member

No description provided.

onurctirtir
onurctirtir commented Jul 28, 2020
View reviewed changes
@hanefi hanefi self-requested a review July 28, 2020 15:57
hanefi
hanefi requested changes Jul 28, 2020
View reviewed changes
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump alpine docker base image to PG 12.3

Dockerfile
@@ -1,5 +1,5 @@
FROM postgres:12.2
ARG VERSION=9.3.5
FROM postgres:12.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@onurctirtir @hanefi
Fix Dockerfile-alpine for 12.3
7b2ad17 
Co-authored-by: Hanefi Onaldi <[email protected]>
@hanefi hanefi self-requested a review July 28, 2020 16:03
hanefi
hanefi approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
ok to merge after the tests pass

@onurctirtir onurctirtir merged commit 0fc710d into master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanefi hanefi hanefi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurctirtir @hanefi