Updating docs to show the importance of unsetting the tenant in a middleware #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in middleware example
|
@microsoft-github-policy-service agree |
gurkanindibay
approved these changes
May 27, 2023
|
Hey! I'd an issue I've been workin on for the last 5 days with no luck. Just comed to this PR and it's definitely A MUST HAVE to avoid inconsistency in server responses. Posted this question in StackOverflow I'll be updating with the solution soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the middleware example, it is assumed the user always has to have a tenant set. However, it is often better to unset the tenant in the middleware after the request is processed as it is using thread-local. As a rule of thumb, any thread-local should be cleared after request processing in a webserver because webservers reuse threads/processes.