Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.1.0 overwrote 4.0.0 wheel #205

Closed
hrother opened this issue Dec 14, 2023 · 3 comments · Fixed by #206
Closed

Release 4.1.0 overwrote 4.0.0 wheel #205

hrother opened this issue Dec 14, 2023 · 3 comments · Fixed by #206

Comments

@hrother
Copy link

hrother commented Dec 14, 2023

It looks like the publication of the 4.1.0 release overwrote the 4.0.0 wheels on pypi.

image

The broken 4.0.0 wheel now produces this error:

AttributeError: 'Settings' object has no attribute 'TENANT_USE_ASGIREF'

The asgiref support should not be part of 4.0.0 but only of 4.1.0.
@rzwink
Copy link

rzwink commented Dec 14, 2023

We needed to add TENANT_USE_ASGIREF = False
to our applications settings.py to avoid an error we were getting after the happened. FYI.

@hrother
Copy link
Author

hrother commented Dec 14, 2023

Yes that's how we hot fixed the error too.

@ekampf ekampf mentioned this issue Dec 15, 2023
Merged
@hrother
Copy link
Author

hrother commented Dec 19, 2023

I'm sorry but I do not think this issue is fixed yet.

The 4.0.0 wheel on pypi still contains the source code of the 4.1.0 release.

Therefore all django applications which have pinned django-multitenant to 4.0.0 will break when they are reinstalled/redeployed.

@gurkanindibay is it possible to recreate the 4.0.0 wheel and upload it to pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hrother @rzwink