Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do the SDK really need to set an AppTheme? #42

Open
rocboronat opened this issue Jul 30, 2021 · 4 comments
Open

Do the SDK really need to set an AppTheme? #42

rocboronat opened this issue Jul 30, 2021 · 4 comments

Comments

@rocboronat
Copy link

Our project, as a lot of projects out there, specifies an app theme.

It seems that the SDK also specifies an app theme in its AndroidManifest, so it conflicts with the project's one.

The question: is it really needed?

This is the error message it launches:

Manifest merger failed : Attribute application@theme value=(@style/FewlapsTheme) from AndroidManifest.xml:37:9-45
	is also present at [com.citrix.android:authmanagerlitelib:Release_21.5.0-1] AndroidManifest.xml:15:9-40 value=(@style/AppTheme).
	Suggestion: add 'tools:replace="android:theme"' to <application> element at AndroidManifest.xml:30:5-309:19 to override.
@terry-citrix
Copy link
Member

Hi @rocboronat , we cover this issue a bit in our Troubleshooting section. See https://developer.cloud.com/citrixworkspace/mobile-application-integration/android-native/docs/troubleshooting#how-to-resolve-a-gradle-build-error-androidmanifestxml-error-attribute-applicationtheme-is-also-present-at-comcitrixandroidauthmanagerlitelib-

We probably should not define a theme in that library, and that's something that we'll look into. In the meantime you can override this theme with your own. The suggestion is to add 'tools:replace="android:theme"' to the element in the AndroidManifest.xml file.

@rocboronat
Copy link
Author

Yes, obviously I did it, but please, fix it for good. Closing this issue is unexpected if you intend to keep the project sane.

@terry-citrix terry-citrix reopened this Sep 10, 2021
@terry-citrix
Copy link
Member

Ah, I see. You were asking for a code change, rather than asking a technical question. I've re-opened the issue so that we can track it publicly as an enhancement request.

@rocboronat
Copy link
Author

Yap. Thanks for reopening the issue 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants