-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delimiters in disambiguate_InitializeWithButNoDisambiguation #56
Comments
That's actually speced: |
Thank you, @adam3smith. That’s an easy change but it breaks at least one other test, disambiguate_YearSuffixWithEtAlSubsequent. If I have
for the first line of that test instead of what it expects,
The two test’s citation attributes look very similar (below). What I do see is different is that one has
|
There are probably enough delimiter threads out there. I’m happy to keep plugging along and figure it out. This is where I saw “in-text” might be relevant, though I’ve not bothered to fully parse this section of code https://github.com/Juris-M/citeproc-js/blob/84a3916a20fc33ab53a2b57a8af1fe3b9d82452c/src/api_cite.js#L892 |
Final note on this: I adjusted my code as follows and it’s passing both kinds of tests. Citations that are citationGroupingDelimiter
?? (placement == .inText
? CitationElement.defaultDelimiter
: layout.delimiter ?? CitationElement.defaultDelimiter) We’ll see how far this takes me 😄 |
Great! This solves my confusion. |
I am stumped on disambiguate_InitializeWithButNoDisambiguation. My result is
but the expected result is
I am not seeing the setting that would override
<layout delimiter=“;”>
for use between the two citations — at least not in a way that still passes the other tests.I think it must be simple but reading previous issues like #50 hasn’t turned on a lightbulb yet. This is the relevant content:
The text was updated successfully, but these errors were encountered: