Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For dependent styles: Clicking "edit" does nothing #191

Open
leejones-san opened this issue Jan 18, 2016 · 4 comments
Open

For dependent styles: Clicking "edit" does nothing #191

leejones-san opened this issue Jan 18, 2016 · 4 comments

Comments

@leejones-san
Copy link

When I open a style and click "edit", nothing happens. This issue recurs on Firefox, Chrome and IE.

@zuphilip
Copy link
Member

What do you mean exactly?

I see the menu showing Undo and Redo under Edit:

edit-click

@leejones-san
Copy link
Author

Apologies for being unclear. I mean when I click the button highlighted here (or the "edit style" button after clicking "view style"), nothing happens. The button does not work.

untitled

@zuphilip
Copy link
Member

Well, the edit normally works. However, the style you are trying to edit is a dependent style and the same as some more general Taylor & Francis style. If you click on the link after "same as" then you should be able to edit this parent style.

However, it seems that edit link for dependent style should be either deactivated or linked to the parent style. @adam3smith

[fixed typo, AS]

@adam3smith adam3smith changed the title Clicking "edit" does nothing For dependent styles: Clicking "edit" does nothing Nov 15, 2016
@bschilder
Copy link

bschilder commented Sep 20, 2021

@zuphilip, would it not be better to provide some indicator to users that these entries are not editable?

Some potential ways to do this:

  1. Remove or disable the Edit button for these entries and replace it with a note indicating the restrictions.
  2. Enable Edit for these entries, but create copy with an autogenerated unique ID (eg by adding a number to the original entry's name).
  3. Provide a pop up message upon clicking Edit , warning users they can't actually edit.

Option 2 would probably be my preferred choice, because it lets users edit the CSL files (which is what users will be expecting from CSL Editor) while preserving the integrity of the (vetted?) dependent styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants