From b2c6bb7bdd58fd96dd0ad6a2fb6560641e326ae5 Mon Sep 17 00:00:00 2001
From: JosePabloOcampo1212 <jp.ocampo1000@gmail.com>
Date: Tue, 19 Nov 2024 09:50:00 -0600
Subject: [PATCH] devel changes in module discovery

---
 ...uthentication_import_certificate_p12_v1.py |  3 ++-
 plugins/modules/discovery.py                  | 25 ++++---------------
 plugins/modules/discovery_v1.py               | 22 ++++------------
 plugins/modules/event_snmp_config_v1_info.py  |  2 ++
 4 files changed, 14 insertions(+), 38 deletions(-)

diff --git a/plugins/modules/authentication_import_certificate_p12_v1.py b/plugins/modules/authentication_import_certificate_p12_v1.py
index 604186970..09fe1f9f4 100644
--- a/plugins/modules/authentication_import_certificate_p12_v1.py
+++ b/plugins/modules/authentication_import_certificate_p12_v1.py
@@ -19,8 +19,9 @@
 options:
   listOfUsers:
     description: ListOfUsers query parameter. Specify whether the certificate will be
-      used for controller ("server"), disaster recovery ("ipsec") or both ("server, ipsec").If no value is
+      used for controller ("server"), disaster recovery ("ipsec") or both ("server, ipsec"). If no value is
       provided, the default value taken will be "server".
+    type: list
     elements: dict
     suboptions:
       description:
diff --git a/plugins/modules/discovery.py b/plugins/modules/discovery.py
index 5b884762c..699ed0a11 100644
--- a/plugins/modules/discovery.py
+++ b/plugins/modules/discovery.py
@@ -171,18 +171,6 @@
   snmpPrivProtocol:
     description: SNMP privacy protocol. 'AES128'.
     type: str
-  snmpROCommunity:
-    description: SNMP RO community of the devices to be discovered.
-    type: str
-  snmpROCommunityDesc:
-    description: Description for SNMP RO community.
-    type: str
-  snmpRWCommunity:
-    description: SNMP RW community of the devices to be discovered.
-    type: str
-  snmpRWCommunityDesc:
-    description: Description for SNMP RW community.
-    type: str
   snmpRoCommunity:
     description: SNMP RO community of the devices to be discovered.
     type: str
@@ -204,9 +192,6 @@
   timeOut:
     description: Time to wait for device response.
     type: int
-  timeout:
-    description: Time to wait for device response in seconds.
-    type: int
   updateMgmtIp:
     description: Updates Management IP if multiple IPs are available for a device. If
       set to true, when a device is rediscovered with a different IP, the management
@@ -368,13 +353,13 @@
     snmpMode: string
     snmpPrivPassphrase: string
     snmpPrivProtocol: string
-    snmpROCommunity: string
-    snmpROCommunityDesc: string
-    snmpRWCommunity: string
-    snmpRWCommunityDesc: string
+    snmpRoCommunity: string
+    snmpRoCommunityDesc: string
+    snmpRwCommunity: string
+    snmpRwCommunityDesc: string
     snmpUserName: string
     snmpVersion: string
-    timeout: 0
+    timeOut: 0
     userNameList:
     - string
 
diff --git a/plugins/modules/discovery_v1.py b/plugins/modules/discovery_v1.py
index 5e2bb3fb7..96c754eb3 100644
--- a/plugins/modules/discovery_v1.py
+++ b/plugins/modules/discovery_v1.py
@@ -176,18 +176,6 @@
   snmpPrivProtocol:
     description: SNMP privacy protocol. 'AES128'.
     type: str
-  snmpROCommunity:
-    description: SNMP RO community of the devices to be discovered.
-    type: str
-  snmpROCommunityDesc:
-    description: Description for SNMP RO community.
-    type: str
-  snmpRWCommunity:
-    description: SNMP RW community of the devices to be discovered.
-    type: str
-  snmpRWCommunityDesc:
-    description: Description for SNMP RW community.
-    type: str
   snmpRoCommunity:
     description: SNMP RO community of the devices to be discovered.
     type: str
@@ -372,13 +360,13 @@
     snmpMode: string
     snmpPrivPassphrase: string
     snmpPrivProtocol: string
-    snmpROCommunity: string
-    snmpROCommunityDesc: string
-    snmpRWCommunity: string
-    snmpRWCommunityDesc: string
+    snmpRoCommunity: string
+    snmpRoCommunityDesc: string
+    snmpRwCommunity: string
+    snmpRwCommunityDesc: string
     snmpUserName: string
     snmpVersion: string
-    timeout: 0
+    timeOut: 0
     userNameList:
     - string
 
diff --git a/plugins/modules/event_snmp_config_v1_info.py b/plugins/modules/event_snmp_config_v1_info.py
index 61cd74747..a3f3fae4a 100644
--- a/plugins/modules/event_snmp_config_v1_info.py
+++ b/plugins/modules/event_snmp_config_v1_info.py
@@ -9,6 +9,8 @@
 ---
 module: event_snmp_config_v1_info
 short_description: Information module for Event Snmp Config V1
+description:
+  - This module retrieves SNMP configuration information for events in Cisco DNA Center.
 version_added: '3.1.0'
 extends_documentation_fragment:
   - cisco.dnac.module_info