Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to use the latest Python version #81

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Update Dockerfile to use the latest Python version #81

merged 3 commits into from
Jan 31, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 31, 2024 •
edited
Loading

🗣 Description

This pull request updates Dockerfile to use the latest Python version and the most recent incarnation of our VM developer distro email address.

💭 Motivation and context

I was making some changes in this repo already (#80) and figured we may as well be current.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Jan 31, 2024
@jsf9k jsf9k self-assigned this Jan 31, 2024
@jsf9k jsf9k marked this pull request as ready for review January 31, 2024 16:45
dav3r
dav3r approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@jsf9k jsf9k requested a review from a team January 31, 2024 16:53
@jsf9k jsf9k force-pushed the improvement/use-latest-python branch from 01d489a to 39a9d7e Compare January 31, 2024 17:36
@jsf9k jsf9k enabled auto-merge January 31, 2024 17:37
@jsf9k jsf9k merged commit 40f4de9 into develop Jan 31, 2024
17 checks passed
@jsf9k jsf9k deleted the improvement/use-latest-python branch January 31, 2024 17:45
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Jan 31, 2024
@jsf9k
Update Docker composition to use the latest cisagov/saver Docker image
13481be 
See there PRs for more information about the changes:
- cisagov/saver#80
- cisagov/saver#81
@jsf9k jsf9k mentioned this pull request Jan 31, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @dv4harr10