Default to building universal wheel #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanLee1521
force-pushed
the
universal_wheel
branch
from
58fa0f0
to
c74b428
Compare
Because the project is pure Python and 2/3 compatible, we can build a single wheel out of the package using: `$ python setup.py bdist_wheel` Ref: https://packaging.python.org/tutorials/distributing-packages/\#universal-wheels
|
Are you sure? I think |
|
It does, but the "universal-ness" of a package depends only on itself, not on its dependencies. |
|
OK, that seems reasonable (and yeah, rereading the docs, I understand better now). The examples in the docs say |
|
Yes, I've used true in other places (and think it's clearer / better documenting). I also tested building the wheel locally. |
|
Cool - looks good to me, but deferring to @h-m-f-t for merges of PyPi-related stuff, since I don't have any role in the packaging process (and haven't ever managed a PyPi package). |
cisagovbot
pushed a commit
that referenced
this pull request
Jan 7, 2023
Update Go installation in the `build.yml` workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the project is pure Python and 2/3 compatible,
we can build a single wheel out of the package using:
$ python setup.py bdist_wheelRef: https://packaging.python.org/tutorials/distributing-packages/#universal-wheels