From 659a9eb05185633c4ee1cc5e88f0cdbc94f94cc2 Mon Sep 17 00:00:00 2001 From: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com> Date: Fri, 3 Feb 2023 14:04:21 -0500 Subject: [PATCH 1/2] Adjust key order in the build workflow Sort all pre-`steps` keys alphabetically descending. Sorting all keys alphabetically would be somewhat onerous because the `strategy` key would come after the `steps` key even though it's configuration information. We can at least sort everything but the `steps` key in alphabetically descending order and make the `steps` the last for a job. --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 00b6dc7..82f1382 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -195,10 +195,10 @@ jobs: uses: mxschmitt/action-tmate@v3 if: env.RUN_TMATE build: - runs-on: ${{ matrix.os }} needs: - lint - test + runs-on: ${{ matrix.os }} strategy: fail-fast: false matrix: @@ -248,9 +248,9 @@ jobs: uses: mxschmitt/action-tmate@v3 if: env.RUN_TMATE test-build: - runs-on: ${{ matrix.os }} needs: - build + runs-on: ${{ matrix.os }} strategy: fail-fast: false matrix: From 0f3dd3911b05a9488cf13c34d46ca19d62a875ff Mon Sep 17 00:00:00 2001 From: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com> Date: Fri, 3 Feb 2023 14:14:05 -0500 Subject: [PATCH 2/2] Make build workflow job names more descriptive Add `name` keys to the `test`, `build`, and `test-build` jobs that are both more descriptive and include the Python version from the job's matrix. This will produce consistent and more helpful job names in the GitHub Actions log in the GitHub web UI. --- .github/workflows/build.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 82f1382..ab4a66f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -103,6 +103,7 @@ jobs: uses: mxschmitt/action-tmate@v3 if: env.RUN_TMATE test: + name: test source - py${{ matrix.python-version }} runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -195,6 +196,7 @@ jobs: uses: mxschmitt/action-tmate@v3 if: env.RUN_TMATE build: + name: build wheel - py${{ matrix.python-version }} needs: - lint - test @@ -248,6 +250,7 @@ jobs: uses: mxschmitt/action-tmate@v3 if: env.RUN_TMATE test-build: + name: test built wheel - py${{ matrix.python-version }} needs: - build runs-on: ${{ matrix.os }}