Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to stable APIs #683

Closed
thepra opened this issue Jul 14, 2022 · 6 comments
Closed

Update to stable APIs #683

thepra opened this issue Jul 14, 2022 · 6 comments

Comments

@thepra
Copy link

thepra commented Jul 14, 2022

Describe the problem

As in this issue I figured that cinny is using and old endpoint:
_matrix/client/unstable/org.matrix.msc2432/rooms/:room_id/aliases

meanwhile the stable endpoints are:
/_matrix/client/r0/rooms/{roomId}/aliases or /_matrix/client/v3/rooms/{roomId}/aliases

Describe the solution you'd like

Could Cinny update this endpoints? (which make newer matrix server like dendrite to fail the calls given that it doesn't have no more that deprecated endpoint)

Alternatives considered

No response

Additional context

No response

@ajbura
Copy link
Member

ajbura commented Jul 15, 2022

@thepra This needs to be done in matrix-js-sdk as we are using that.

@aaronraimist
Copy link

@kfiven
Copy link
Collaborator

kfiven commented Jul 15, 2022

@aaronraimist @thepra #624 we also use the stable function but this is still in the dev branch and hasn't been released.

@kfiven
Copy link
Collaborator

kfiven commented Jul 15, 2022

plus it's not just one unstable API call in js-sdk, there are more element-hq/element-web#22839

@thepra
Copy link
Author

thepra commented Jul 17, 2022

damn!

@kfiven
Copy link
Collaborator

kfiven commented Aug 10, 2022

The specific case of room alias API call has now stable API and landed in Cinny 2.1.0, others are not cinny issue but js-sdk's.

@kfiven kfiven closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants