Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL detection includes '>' in link #236

Closed
reinerh opened this issue Jan 15, 2022 · 2 comments
Closed

URL detection includes '>' in link #236

reinerh opened this issue Jan 15, 2022 · 2 comments
Labels
area: timeline type: bug Something isn't working

Comments

@reinerh
Copy link

reinerh commented Jan 15, 2022

Describe the bug

I'm using a matrix twitter bridge which regularly posts URLs into a room.
The URLs are surrounded by <...>, but cinny thinks the closing > is part of the link.
See attached screenshot, where the closing > is also colored in blue.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any room.
  2. Post a link surrounded with <>, e.g.: <https://example.com>
  3. The link is now invalid (and cinny also appends a ; at its end)

Expected behavior

> should not get detected as part of the URL, so that when you click on the URL, you land on the actual target.

Screenshots

cinny

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox 96.0
  • Version: Cinny 1.6.1

Additional context

I also checked the behavior of Element, and there > is not part of the link.

@kfiven kfiven added the type: bug Something isn't working label Jan 21, 2022
@ajbura
Copy link
Member

ajbura commented Jan 25, 2022

This is an issue with Linkifyjs nfrasser/linkifyjs#350

@kfiven
Copy link
Collaborator

kfiven commented Aug 22, 2022

Fixed in #665

@kfiven kfiven closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: timeline type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants