Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll to bottom in unfocused window but stop sending read receipt #2214

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Feb 17, 2025

Description

Fixes #1500

scroll to bottom in unfocused window but stop sending read receipt.

After regaining focus markAsRead if all new event are in view or scroll to new message divider

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Feb 17, 2025

Preview: https://2214--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@BareTuna
Copy link

Nice work, thank you ❤️

I've tested it a little bit, and for me it's not sending the read receipts after regaining focus and all new messages are in view.

image

In this state, if I scroll up a little bit (specifically, when the "Jump to Latest" appears), then back down it sends the read receipt.

Otherwise it seems to work as expected.

@kfiven kfiven merged commit b63868b into dev Feb 21, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New messages don't scroll to bottom when tab is out of focus
3 participants