Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor text of user pill should contain only display name and room mention the room alias or ID #2064

Open
bkil opened this issue Nov 25, 2024 · 2 comments

Comments

@bkil
Copy link

bkil commented Nov 25, 2024

Describe the bug

Generated formatted_body in JSON is not compliant with the specification:

Reproduction

Send in a room mention and a user mention with tab-completion. The resulting JSON body will include the following field:

"formatted_body": "Hello <a href=\"https://matrix.to/#/@phishbot:matrix.org\">@Phish Bot</a> come join <a href=\"https://matrix.to/#/#gemiweb0:matrix.org\">#gemiweb0, the HTML subset</a>",

Expected behavior

The resulting JSON body should include the following field:

"formatted_body": "Hello <a href=\"https://matrix.to/#/@phishbot:matrix.org\">Phish Bot</a> come join <a href=\"https://matrix.to/#/#gemiweb0:matrix.org\">#gemiweb0:matrix.org</a>",

Platform and versions

Cinny Web v4.2.3

Additional context

No response

@kfiven
Copy link
Collaborator

kfiven commented Nov 25, 2024

The spec example shows the what you mentioned in Reproduction:
image

Expected behaviour would not be spec compliant.

@bkil
Copy link
Author

bkil commented Nov 25, 2024

You are right. I have now updated the description. Note that neither the example JSON, nor the text implies that an @ sign should be included, so Cinny is still in error in both cases.

@bkil bkil changed the title Pill user and room mention anchor text should contain mxid, not display name Anchor text of user pill should contain only display name and room mention the room alias or ID Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants