Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correcting the script path for minikube installation steps in do… #3111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-cryptic
Copy link

@d-cryptic d-cryptic commented Nov 14, 2024

Describe what changes this pull request brings

  • Updated the docs with the correct path for minikube-install-hook.sh script.

Related issue

#2980

Before change

image

After Change

image

@d-cryptic d-cryptic requested review from mtardy and a team as code owners November 14, 2024 18:26
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 75cc683
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/673640ec1425720008f2e65f
😎 Deploy Preview https://deploy-preview-3111--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-cryptic
Copy link
Author

Hi,
I only found a single reference for install-hooks scripts.
I have a query regarding tetragon-oci-hook-setup in this documentation page.
This ./contrib/tetragon-rthooks/tetragon-oci-hook-setup not present in current main branch.
Does this needs to be changed too? if so, what's the correct script path for this?

image

@mtardy
Copy link
Member

mtardy commented Nov 19, 2024

I have a query regarding tetragon-oci-hook-setup in this documentation page.
This ./contrib/tetragon-rthooks/tetragon-oci-hook-setup not present in current main branch.
Does this needs to be changed too? if so, what's the correct script path for this?

This is a binary you need to compile in order for it to be around :)

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the change :)

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Nov 19, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you shorten your commit message a little bit?

Error: ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 80)

@paularah
Copy link
Contributor

@d-cryptic do you need help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants