Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify classic / helm mode incompatibilities #1869

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Clarify classic / helm mode incompatibilities #1869

merged 1 commit into from
Aug 24, 2023

Conversation

michi-covalent
Copy link
Contributor

No description provided.

@michi-covalent michi-covalent requested a review from giorio94 July 27, 2023 00:12
@michi-covalent michi-covalent requested a review from a team as a code owner July 27, 2023 00:12
@michi-covalent michi-covalent requested a review from derailed July 27, 2023 00:12
@michi-covalent michi-covalent temporarily deployed to ci July 27, 2023 00:12 — with GitHub Actions Inactive
giorio94
giorio94 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated Show resolved Hide resolved
@michi-covalent michi-covalent temporarily deployed to ci August 1, 2023 00:52 — with GitHub Actions Inactive
@michi-covalent
Copy link
Contributor Author

@derailed ping!

@michi-covalent
Copy link
Contributor Author

@cilium/cli ping!

derailed
derailed approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michi-covalent LGTM - nice work!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 24, 2023
@tklauser tklauser merged commit 0b799f6 into main Aug 24, 2023
@tklauser tklauser deleted the pr/michi/warnings branch August 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michi-covalent @derailed @giorio94 @tklauser