Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: Don't disable L7 proxy when installing with WireGuard enabled #1405

Closed
brb opened this issue Feb 20, 2023 · 2 comments · Fixed by #1419
Closed

install: Don't disable L7 proxy when installing with WireGuard enabled #1405

brb opened this issue Feb 20, 2023 · 2 comments · Fixed by #1419
Assignees
@Neilblaze
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request

Comments

@brb
Copy link
Member

brb commented Feb 20, 2023

Since cilium/cilium#19401 (to be released in v1.14) we no longer need to disabled the L7 proxy when WireGuard is enabled on the > v1.13 Cilium (the relevant log message L7 proxy disabled due to Wireguard encryption).

As a bonus, we can remove the Wireguard does not support node encryption yet warning too.
@brb brb added kind/feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 20, 2023
@brb brb changed the title Don't disable L7 proxy when installing with WireGuard enabled install: Don't disable L7 proxy when installing with WireGuard enabled Feb 20, 2023
@tklauser tklauser mentioned this issue Feb 21, 2023
Closed
@Neilblaze
Copy link
Contributor

Neilblaze commented Feb 26, 2023 •
edited
Loading

@brb If this is up for grabs, I'd love to work on this. Would you mind assigning me this? 😄

@brb
Copy link
Member Author

brb commented Feb 27, 2023

@Neilblaze 👍

@Neilblaze Neilblaze mentioned this issue Feb 27, 2023
Merged
@SixFive7 SixFive7 mentioned this issue Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neilblaze Neilblaze

Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enabled l7Proxy & removed err.log message for WireGuard Neilblaze/cilium-cli
2 participants
@brb @Neilblaze