Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L7 policy manifest can no longer be applied directly after #1267 #1337

Closed
tklauser opened this issue Jan 13, 2023 · 1 comment
Closed

L7 policy manifest can no longer be applied directly after #1267 #1337

tklauser opened this issue Jan 13, 2023 · 1 comment
Labels
kind/bug Something isn't working

Comments

@tklauser
Copy link
Member

tklauser commented Jan 13, 2023

As reported by @danistrebel, it looks like #1267 broke some external resources:

@tklauser I think this commit broke the sample at https://play.instruqt.com/embed/isovalent/tracks/cilium-service-mesh/challenges/l7-traffic-mgmt/assignment that directly applies the resource from the master

kubectl -n cilium-test apply -f https://raw.githubusercontent.com/cilium/cilium-cli/master/connectivity/manifests/client-egress-l7-http.yaml

Maybe there's already an issue tracked for this that I wasn't able to spot. In which case please ignore.

@tklauser tklauser added the kind/bug Something isn't working label Jan 13, 2023
tklauser referenced this issue Jan 13, 2023
A configurable domain allows us to run the PodToWord test in
an environment where external traffic only allow for specific domains.
This also gives us the ability to swap the domain in test environments
to better handle flaky tests.

Signed-off-by: Birol Bilgin <[email protected]>
@tklauser
Copy link
Member Author

I've notified the authors of the instruqt lab and they will change it to use the respective manifests from the main Cilium repo, i.e. kubectl apply -f https://raw.githubusercontent.com/cilium/cilium/v1.12/examples/kubernetes/servicemesh/envoy/client-egress-l7-http.yaml.

Looks like there's nothing else to be done in cilium-cli, thus closing the issue

@tklauser tklauser closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant