Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for reverting a change back to original promise #1

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix for reverting a change back to original promise #1

merged 1 commit into from
Mar 17, 2022

Conversation

ultish
Copy link
Owner

@ultish ultish commented Mar 17, 2022

When @selected is a promise initially, you update it to a non-promise value, and then revert the change back to the original promise value, EPS was ignoring the change as it still held a reference to _lastSelectedPromise.
Should fix cibernox#1467

@ultish
fix for reverting a change back to original promise
130c022 
When @selected is a promise initially, you update it to a non-promise value, and then revert the change back to the original promise value, EPS was ignoring the change as it still held a reference to _lastSelectedPromise.
@ultish ultish merged commit 9b90921 into master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select is not properly reseted when selected is a promise
1 participant
@ultish