Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopkg does not work with sub-packages #43

Closed
alecthomas opened this issue Apr 5, 2016 · 1 comment
Closed

gopkg does not work with sub-packages #43

alecthomas opened this issue Apr 5, 2016 · 1 comment
Assignees

Comments

@alecthomas
Copy link

This is not an issue with readline itself, but impacts uses of it via gopkg. See niemeyer/gopkg#9 for details.

Basically, gopkg only works correctly with single-package repositories. Because gopokg.in/chzyer/readline.v1 imports github.com/chzyer/readline/runes, both repositories will be pulled in, but the latter be at HEAD on master.

I don't have a solution to this unfortunately, I just noticed it when pulling in readline via otto.

@chzyer
Copy link
Owner

chzyer commented Apr 5, 2016

Thanks for the notice.
It seems the only way is remove the "runes" sub package to readline, but that isn't backward compatible.
So I will copy runes to readline, remove the reference to runes and keep the runes package.

@chzyer chzyer self-assigned this Apr 5, 2016
@alecthomas alecthomas changed the title gopokg does not work with sub-packages gopkg does not work with sub-packages Apr 5, 2016
@chzyer chzyer closed this as completed in 6cc043d Apr 6, 2016
chzyer added a commit that referenced this issue Apr 6, 2016
Fix #43 , remove sub-package for gopkg compatiblity
@chzyer chzyer removed the in progress label Apr 6, 2016
lunixbochs pushed a commit to lunixbochs/readline that referenced this issue May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants