You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I want to create a YAML text from a YAML dictionary, I must first create a Yaml::Hash value. In order to do that, I have to also use linked_hash_map crate. This touching yaml-rust's implementation detail and pray that it does not switch to something else (or having an incompatible version).
Proposals
Do one of the following:
Don't use linked_hash_map::LinkedHashMap directly, instead, create a wrapper type and expose it.
Alternatively, still use linked_hash_map::LinkedHashMap, but also expose it by pub use linked_hash_map. This action requires mininal effort, but this would also mean that yaml-rust's semantic versioning now depends on linked-hash-map as well.
P.S. This issue need a better title. Any suggestion?
The text was updated successfully, but these errors were encountered:
@chyh1990 Either way is fine to me. This is a choice for you — the maintainer to make. In my opinion, the first choice would make switching between implementations easier, while the second choice is not a breaking change.
Problem
When I want to create a YAML text from a YAML dictionary, I must first create a
Yaml::Hash
value. In order to do that, I have to also uselinked_hash_map
crate. This touching yaml-rust's implementation detail and pray that it does not switch to something else (or having an incompatible version).Proposals
Do one of the following:
Don't use
linked_hash_map::LinkedHashMap
directly, instead, create a wrapper type and expose it.Alternatively, still use
linked_hash_map::LinkedHashMap
, but also expose it bypub use linked_hash_map
. This action requires mininal effort, but this would also mean that yaml-rust's semantic versioning now depends on linked-hash-map as well.P.S. This issue need a better title. Any suggestion?
The text was updated successfully, but these errors were encountered: