Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsChromium needs updating for VS 2019 #49

Closed
randomascii opened this issue Dec 7, 2018 · 5 comments
Closed

VsChromium needs updating for VS 2019 #49

randomascii opened this issue Dec 7, 2018 · 5 comments

Comments

@randomascii
Copy link

VsChromium works with VS 2019 Preview - for now. However it will stop working in the future. Details can be found here:

https://blogs.msdn.microsoft.com/visualstudio/2018/05/16/improving-the-responsiveness-of-critical-scenarios-by-updating-auto-load-behavior-for-extensions/

I followed the instructions and found this entry in the activity log:

618 2018/12/07 18:34:22.913 Warning SyncAutoLoadedExtensions Extension 'VsChromium' uses the 'synchronous auto-load' feature of Visual Studio. This feature will no longer be supported in a future Visual Studio 2019 update, at which point this extension will not work. Please contact the extension vendor to get an update. (UI Context: {f1536ef8-92ec-443c-9ed7-fdadf150da82} Package Guid: {a10cf7af-5f0a-4502-b44b-51ff1b7c8a87})
@rpaquay
Copy link
Contributor

rpaquay commented May 28, 2019

There is a pre-release addressing this issue: https://github.com/chromium/vs-chromium/releases/tag/v0.9.31

@randomascii
Copy link
Author

Installed and testing - working well so far

@rpaquay
Copy link
Contributor

rpaquay commented May 29, 2019

As mentioned in the release notes, this pre-release has a regression with displaying icons for known file types. Instead of displaying icons specific to known file types (e.g. C, C++, C#, etc), we display a single generic "text file" icon. This is because an undocumented API has disappeared, and it is unclear what to use instead.

@randomascii
Copy link
Author

I never noticed the icons. I guess I'm noticing them now but when I check on 0.9.30 - still installed on a different machine - I see the same generic text icons.

In both cases I am using VS 2019. I tested with VS 2017 (also 0.9.30) and I still see generic text icons in the search results. So, I'm not sure when this last worked, but it is not a regression that bothers me personally.

@rpaquay
Copy link
Contributor

rpaquay commented Sep 10, 2019

@rpaquay rpaquay closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants