Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default to reflect new chromium enlistment layout #34

Closed
rpaquay opened this issue Aug 3, 2017 · 1 comment
Closed

Update default to reflect new chromium enlistment layout #34

rpaquay opened this issue Aug 3, 2017 · 1 comment

Comments

@rpaquay
Copy link
Contributor

rpaquay commented Aug 3, 2017

The default layout of a chromium enlistement has changed quite since the last time the defaults were updated.

See #31 (comment)

Looking at that file I can see other changes which should be made. Now that gn has replaced gyp the explicit references to Debug and Release directories don't make sense. It would be better to replace:

out/Debug/gen/webkit/bindings/
out/Release/gen/webkit/bindings/

with:

out/*/gen/webkit/bindings

except that that directory doesn't exist anymore so that I think what is actually wanted is:

out/*/gen/blink/bindings


Note: Source files containing defaults are:

rpaquay added a commit that referenced this issue Aug 4, 2017
@rpaquay
Copy link
Contributor Author

rpaquay commented Nov 17, 2017

Fixed

@rpaquay rpaquay closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant