Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsChromium should visually indicate when it hits the maximum # of results #25

Closed
randomascii opened this issue Nov 16, 2016 · 4 comments

Comments

@randomascii
Copy link

I just tried searching for "v8" (including the quotes) in one of my repos using VsChromium. The results vary from time to time. If I repeatedly paste in the string then the results keep changing.

It looks like VsChromium stops after the first 10,000 results, and the multi-threaded nature of the search means that the first 10,000 results are different every time, but there is not a great indication that the search was aborted.

I've hit variations on this issue a couple of times. It's not a bug, but some sort of indication that the results are partial would make it more obvious that the search should be constrained more heavily, or Tools-> Options should be used to increase the maximum number of results.

@rpaquay
Copy link
Contributor

rpaquay commented Nov 16, 2016

There is a Tools | Options page to change these values:

image

I agree it would be nice to have an indicator.

@rpaquay
Copy link
Contributor

rpaquay commented Nov 16, 2016

Oh nevermind, you found the options page, you are requesting that there is an indicator to go change the options, correct?

@randomascii
Copy link
Author

A visual indicator, yes. Although I think that in most cases my response would not be to change the maximum but to filter the results more. It could say something like:

"Maximum number of results hit - some results omitted. Use Tools-> Options to increase the limit, or change your query to exclude more results."

Outlook has a warning like this if you do a search query that returns too many results.

@rpaquay
Copy link
Contributor

rpaquay commented Nov 16, 2016

Fixed in a21a076

@rpaquay rpaquay closed this as completed Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants