feedback project

[mirko06854]

Review form

1. General

1.1. How creative is the project? (0: I've seen this on Youtube, 1:
4

1.2. How difficult was it to implement the project? 4

1.3. List 3 positive aspects of the project. Motivate your
selection.

1. Nice the possibility to choose the windows size
2. Nice backend and well documented
3. nice the separation of concerns using MVC model. Appreciated the use of more classes to reason on different shapes, ensuring better encapsulation and modularity.

1.4. List 3 negative aspects of the project. Motivate your
selection.

1. Didn't like too much the use of "else if" chain in Controller class, I would have used switch case

2. I would have liked to have some buttons to save the json or images instead of pressing keyboard keys

3. Missing a description to specify by who this app should be used

4. Programming techniques

2.1. Evaluate how well 5 programming techniques we learned
throughout the course were adopted in the project. Assign a mark
from 0 to 5 to each technique, where 0 means completely incorrect
usage and 5 means perfect usage.

1. Test Hooks : 4

2. Collections: 4

3. Method overriding: 4

4. Castings: 4

5. Try-Catch-Blocks : 3 maybe could be better to pass directly the integer values in some methods of OpenSimplexNoise, not sure anyway

6. Git repository

3.1. How appropriate is the .gitignore file of the project? 5 , also nicely commented

3.2. How appropriate is the README.md file of the project? 4

4. Maven

4.1. Can you compile the project via Maven?
2

4.2. Can you clean the project via Maven? 2

4.3. Can you run the project via Maven? Check README.md on how to
run the project. 2

4.4. Are the project's dependencies appropriately configured in
pom.xml? 2

4.5. Are all Maven plugins appropriately configured in pom.xml? 2

4.6. Does the project adopt Maven's standard directory layout? 2

5. Testing
   5.1. Are all tests passing? Run mvn test. 2

5.2. How well do the tests cover the code? 3

5.3. Do the tests actually verify the expected behavior of the
program? 5

5.4. How well can you understand what the tests are supposed to
verify? 5

6. Documentation

6.1. How understandable is the Javadoc written for classes, fields
and methods of the program? 5

6.2. How useful is the Javadoc written for classes, fields and
methods of the program? 4

6.3. Can you generate documentation files for this project? Run mvn
javadoc:javadoc. 2

6.4. How adequate are the non-javadoc comments written throughout
the code? 3

7. Code quality

7.1. Is the code style adopted throughout the project consistent?
Consider how whitespace is represented (spaces or tabs), tab size,
naming conventions for classes, methods and variables, indentation,
braces usage, line width. See Google Java Style Guide as an example
of code style guidelines. 2

7.2. How would you rate the project in terms of code duplication?
1 (some duplication in GenerateSimplexTitles class for example)

7.3. How easy it is to understand how the program works by looking
at the source code? 1

7.4. Is the program excessively inefficient? 3

7.5. Does the program crash unexpectedly (e.g. by an uncaught
exception)? 3