Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not remap symbolMapping entry when merging reflections #193

Closed
rbuckton opened this issue Oct 5, 2018 · 0 comments
Closed

Comments

@rbuckton
Copy link

rbuckton commented Oct 5, 2018

When the plugin merges external module reflections it calls CommentsPlugin.removeReflection, which deletes the entry in project.symbolMapping and can break resolution.

Consider tracking the symbol id in https://github.com/christopherthielen/typedoc-plugin-external-module-name/blob/master/plugin.ts#L75 via a call to context.getSymbolID(node.symbol), and updating the entry in project.symbolMapping before calling CommentsPlugin.removeReflection on https://github.com/christopherthielen/typedoc-plugin-external-module-name/blob/master/plugin.ts#L132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant