This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Remove listener when mongos destroyed #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
suggested changes
Dec 12, 2017
|
|
||
| const test = new MongosFixture(); | ||
|
|
||
| describe.only('EventEmitters (Mongos)', function() { |
There was a problem hiding this comment.
Yep 👍 not quite ready for review yet :)
added 2 commits
December 12, 2017 16:22
after servers are created
jlord
changed the title
jlord
changed the title
mbroadst
approved these changes
Dec 13, 2017
|
nice! |
daprahamian
approved these changes
Dec 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of the listeners were being removed when a server was closed, causing a memory leak on reconnect.
This removes the
serverDescriptionChangedlistener when a server has been closed.NODE-1216