fix(retryable-writes): network errors are retryable, inverted logic

NODE-1105
mongodb-js · Dec 1, 2017 · 2727551 · 2727551
1 parent 1efb35a
commit 2727551
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/topologies/mongos.js b/lib/topologies/mongos.js
@@ -900,15 +900,15 @@ var executeWriteOperation = function(self, op, ns, ops, options, callback) {
 
   server[op](ns, ops, options, (err, result) => {
     if (!err) return callback(null, result);
-    if (err instanceof errors.MongoNetworkError) {
+    if (!(err instanceof errors.MongoNetworkError)) {
       return callback(err);
     }
 
     // Pick another server
     server = pickProxy(self);
 
     // No server found error out with original error
-    if (!server) {
+    if (!server || !isRetryableWritesSupported(server)) {
       return callback(err);
     }
 

diff --git a/lib/topologies/replset.js b/lib/topologies/replset.js
@@ -1175,7 +1175,7 @@ var executeWriteOperation = function(self, op, ns, ops, options, callback) {
 
   self.s.replicaSetState.primary[op](ns, ops, options, (err, result) => {
     if (!err) return callback(null, result);
-    if (err instanceof errors.MongoNetworkError) {
+    if (!(err instanceof errors.MongoNetworkError)) {
       return callback(err);
     }