Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up main list - keeping icon & colour when available #68

Closed
chrislennon opened this issue Jan 21, 2018 · 1 comment · Fixed by #74
Closed

Tidy up main list - keeping icon & colour when available #68

chrislennon opened this issue Jan 21, 2018 · 1 comment · Fixed by #74

Comments

@chrislennon
Copy link
Owner

Current:
loads all coins from coins.js which have an icon and provides search for others that don't.

Todo:
Load top X coins from list, search for others - apply the colours and icons to all coins by matching on the ticker.
@chrislennon chrislennon mentioned this issue Jan 21, 2018
Closed
@chrislennon
Copy link
Owner Author

Coins data will be augmented into the multi-select search widget using customProperties.

Custom properties don't current seem to be exposed on the 'addItem' event, a PR has been made by @BJJLangedijk Choices-js/Choices#325

Current WIP branch for this is https://github.com/chrislennon/Crypto-Touchbar-App/tree/feature/display-tidy and pending the PR for Choices a hardcoded patched version will be implemented

@chrislennon chrislennon mentioned this issue Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/display tidy chrislennon/Crypto-Touchbar-App
1 participant
@chrislennon